Compare commits

...
Author SHA1 Message Date
aziz_28002andClaude Sonnet 5 a5bbc24ecf fix: make order search case-insensitive
Runner Test / test (push) Successful in 16s
Runner Test / test (pull_request) Successful in 14s
instr() in SQLite compares bytes, so searching for a customer name
in uppercase (e.g. "JOHN") silently missed lowercase-stored matches
like "John". Lowercase both sides of the order number, name, and
email comparisons so search matches regardless of the case staff
paste in.

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
2026-09-16 20:41:45 +04:00
derrick e493d1592b add:assignment 1 test
Runner Test / test (push) Failing after 17s
2026-09-11 15:25:06 +09:00
2 changed files with 53 additions and 3 deletions
+3 -3
View File
@@ -39,9 +39,9 @@ export async function listOrderSummaries(context: DatabaseContext, query?: strin
const filters = search
? or(
sql`instr(${orders.orderNumber}, ${search}) > 0`,
sql`instr(${users.name}, ${search}) > 0`,
sql`instr(${users.email}, ${search}) > 0`
sql`instr(lower(${orders.orderNumber}), lower(${search})) > 0`,
sql`instr(lower(${users.name}), lower(${search})) > 0`,
sql`instr(lower(${users.email}), lower(${search})) > 0`
)
: undefined;
@@ -0,0 +1,50 @@
import { afterEach, beforeEach, describe, expect, test } from "bun:test";
import type { AppWithContext } from "../app";
import { buildApp } from "../app";
import { createUser } from "../users/user-repository";
let app: AppWithContext;
let employeeCookie = "";
function firstHeader(value: string | string[] | undefined) {
return Array.isArray(value) ? value[0] : value ?? "";
}
async function login(username: string) {
const response = await app.inject({ method: "POST", url: "/api/login", payload: { username } });
return firstHeader(response.headers["set-cookie"]);
}
beforeEach(async () => {
app = await buildApp(":memory:");
await createUser(app.dbContext, {
username: "dev-employee",
name: "Dev Employee",
email: "dev.employee@example.com",
role: "employee"
});
employeeCookie = await login("dev-employee");
});
afterEach(async () => {
await app.close();
});
describe("assignment 1 search behavior", () => {
test("searches orders case-insensitively by customer name", async () => {
const response = await app.inject({
method: "GET",
url: "/api/orders?query=JOHN",
headers: { cookie: employeeCookie }
});
const orders = response.json();
const orderNumbers = orders.map((order: { orderNumber: string }) => order.orderNumber);
expect(response.statusCode).toBe(200);
expect(orderNumbers).toContain("ORD-1001");
expect(orderNumbers).toContain("ORD-1003");
});
});