Compare commits

..
Author SHA1 Message Date
Lena Deriso f4f7f9620f Fix case-insensitive order search
Runner Test / test (push) Successful in 17s
Runner Test / test (pull_request) Successful in 16s
2026-09-11 16:20:08 -04:00
4 changed files with 65 additions and 9 deletions
-1
View File
@@ -8,4 +8,3 @@ bun.lock
*.sqlite-wal
dist
coverage
pi-session*
+1 -4
View File
@@ -1,9 +1,5 @@
# Typescript Full Stack App Agent
## Coding Conventions
- Before planning any code plan, check the `CONTRIBUTING.md` file in the root directory of the project to understand and apply coding conventions for this project
- Instead of reading and parsing the `CONTRIBUTING.md` every time, cache the findings of `CONTRIBUTING.md` and refer to this cache'd file whenever checking the conventions is required
## Output Rules
### Response Style
@@ -180,3 +176,4 @@ Skip `discover_context` for narrow tasks with explicit file targets.
### Boundaries
- Recon is read-only unless user requested implementation.
- Do not treat scout output as complete when evidence suggests missing files.
+4 -4
View File
@@ -35,13 +35,13 @@ function toOrderItemDetail(row: {
}
export async function listOrderSummaries(context: DatabaseContext, query?: string) {
const search = query?.trim().toLowerCase();
const search = query?.trim();
const filters = search
? or(
sql`instr(lower(${orders.orderNumber}), ${search}) > 0`,
sql`instr(lower(${users.name}), ${search}) > 0`,
sql`instr(lower(${users.email}), ${search}) > 0`
sql`instr(LOWER(${orders.orderNumber}), LOWER(${search})) > 0`,
sql`instr(LOWER(${users.name}), LOWER(${search})) > 0`,
sql`instr(LOWER(${users.email}), LOWER(${search})) > 0`
)
: undefined;
@@ -47,4 +47,64 @@ describe("assignment 1 search behavior", () => {
expect(orderNumbers).toContain("ORD-1001");
expect(orderNumbers).toContain("ORD-1003");
});
test("searches orders by mixed-case customer name without matching email", async () => {
const response = await app.inject({
method: "GET",
url: "/api/orders?query=JoHn%20SmItH",
headers: { cookie: employeeCookie }
});
const orders = response.json();
const orderNumbers = orders.map((order: { orderNumber: string }) => order.orderNumber);
expect(response.statusCode).toBe(200);
expect(orderNumbers).toHaveLength(2);
expect(orderNumbers).toContain("ORD-1001");
expect(orderNumbers).toContain("ORD-1003");
});
test("searches orders by uppercase customer email", async () => {
const response = await app.inject({
method: "GET",
url: "/api/orders?query=JOHN.SMITH%40EXAMPLE.COM",
headers: { cookie: employeeCookie }
});
const orders = response.json();
const orderNumbers = orders.map((order: { orderNumber: string }) => order.orderNumber);
expect(response.statusCode).toBe(200);
expect(orderNumbers).toHaveLength(2);
expect(orderNumbers).toContain("ORD-1001");
expect(orderNumbers).toContain("ORD-1003");
});
test("searches orders by lowercase order number", async () => {
const response = await app.inject({
method: "GET",
url: "/api/orders?query=ord-1001",
headers: { cookie: employeeCookie }
});
const orders = response.json();
const orderNumbers = orders.map((order: { orderNumber: string }) => order.orderNumber);
expect(response.statusCode).toBe(200);
expect(orderNumbers).toHaveLength(1);
expect(orderNumbers).toContain("ORD-1001");
});
test("returns no orders when the search term does not match", async () => {
const response = await app.inject({
method: "GET",
url: "/api/orders?query=no-matching-order",
headers: { cookie: employeeCookie }
});
const orders = response.json();
expect(response.statusCode).toBe(200);
expect(orders).toEqual([]);
});
});