Fix case-insensitive order search

apps/api/src/db/init-db.ts

@@ -90,7 +90,6 @@ export function initializeDatabase(sqlite: Database) {
       customer_id TEXT NOT NULL REFERENCES users(id),
       shipping_address_id TEXT NOT NULL REFERENCES addresses(id),
       status TEXT NOT NULL,
-      notes TEXT NOT NULL DEFAULT '',
       created_at TEXT NOT NULL,
       updated_at TEXT NOT NULL
     );
@@ -120,8 +119,4 @@ export function initializeDatabase(sqlite: Database) {
       created_at TEXT NOT NULL
     );
   `);
-
-  if (tableExists(sqlite, "orders") && !columnExists(sqlite, "orders", "notes")) {
-    sqlite.exec(`ALTER TABLE orders ADD COLUMN notes TEXT NOT NULL DEFAULT ''`);
-  }
 }

apps/api/src/db/schema/orders.ts

@@ -9,7 +9,6 @@ export const orders = sqliteTable("orders", {
   customerId: text("customer_id").notNull().references(() => users.id),
   shippingAddressId: text("shipping_address_id").notNull().references(() => addresses.id),
   status: text("status").notNull(),
-  notes: text("notes").notNull().default(""),
   createdAt: text("created_at").notNull(),
   updatedAt: text("updated_at").notNull()
 });

apps/api/src/orders/order-notes-assignment-2.test.ts

@@ -1,106 +0,0 @@
-import { afterEach, beforeEach, describe, expect, test } from "bun:test";
-import type { AppWithContext } from "../app";
-import { buildApp } from "../app";
-import { createUser } from "../users/user-repository";
-
-let app: AppWithContext;
-let employeeCookie = "";
-let customerCookie = "";
-
-function firstHeader(value: string | string[] | undefined): string {
-  return Array.isArray(value) ? value[0] ?? "" : value ?? "";
-}
-
-async function login(username: string) {
-  const response = await app.inject({ method: "POST", url: "/api/login", payload: { username } });
-  return firstHeader(response.headers["set-cookie"]);
-}
-
-beforeEach(async () => {
-  app = await buildApp(":memory:");
-
-  await createUser(app.dbContext, {
-    username: "dev-employee",
-    name: "Dev Employee",
-    email: "dev.employee@example.com",
-    role: "employee"
-  });
-
-  employeeCookie = await login("dev-employee");
-  customerCookie = await login("john-smith");
-});
-
-afterEach(async () => {
-  await app.close();
-});
-
-describe("assignment 2 internal order notes", () => {
-  test("allows employee users to attach notes to an order", async () => {
-    const response = await app.inject({
-      method: "POST",
-      url: "/api/orders/order_1/notes",
-      headers: { cookie: employeeCookie },
-      payload: { notes: "Follow up with warehouse before shipping." }
-    });
-
-    const order = response.json();
-
-    expect(response.statusCode).toBe(200);
-    expect(order.orderNumber).toBe("ORD-1001");
-    expect(order.notes).toBe("Follow up with warehouse before shipping.");
-    expect(order.items).toHaveLength(2);
-  });
-
-  test("returns persisted notes when the order is viewed later", async () => {
-    const updateResponse = await app.inject({
-      method: "POST",
-      url: "/api/orders/order_1/notes",
-      headers: { cookie: employeeCookie },
-      payload: { notes: "Customer requested gift receipt." }
-    });
-
-    expect(updateResponse.statusCode).toBe(200);
-
-    const detailResponse = await app.inject({
-      method: "GET",
-      url: "/api/orders/order_1",
-      headers: { cookie: employeeCookie }
-    });
-
-    expect(detailResponse.statusCode).toBe(200);
-    expect(detailResponse.json().notes).toBe("Customer requested gift receipt.");
-  });
-
-  test("rejects customer users when attaching notes", async () => {
-    const response = await app.inject({
-      method: "POST",
-      url: "/api/orders/order_1/notes",
-      headers: { cookie: customerCookie },
-      payload: { notes: "Customer should not be able to add this." }
-    });
-
-    expect(response.statusCode).toBe(403);
-  });
-
-  test("rejects empty notes", async () => {
-    const response = await app.inject({
-      method: "POST",
-      url: "/api/orders/order_1/notes",
-      headers: { cookie: employeeCookie },
-      payload: { notes: "   " }
-    });
-
-    expect(response.statusCode).toBe(400);
-  });
-
-  test("rejects notes beyond the accepted length limit", async () => {
-    const response = await app.inject({
-      method: "POST",
-      url: "/api/orders/order_1/notes",
-      headers: { cookie: employeeCookie },
-      payload: { notes: "x".repeat(1001) }
-    });
-
-    expect(response.statusCode).toBe(400);
-  });
-});

apps/api/src/orders/order-repository.ts

@@ -39,9 +39,9 @@ export async function listOrderSummaries(context: DatabaseContext, query?: strin
 
   const filters = search
     ? or(
-        sql`instr(lower(${orders.orderNumber}), lower(${search})) > 0`,
-        sql`instr(lower(${users.name}), lower(${search})) > 0`,
-        sql`instr(lower(${users.email}), lower(${search})) > 0`
+        sql`instr(LOWER(${orders.orderNumber}), LOWER(${search})) > 0`,
+        sql`instr(LOWER(${users.name}), LOWER(${search})) > 0`,
+        sql`instr(LOWER(${users.email}), LOWER(${search})) > 0`
       )
     : undefined;
 
@@ -96,7 +96,6 @@ export async function findOrderDetail(context: DatabaseContext, orderId: string)
     id: header.order.id,
     orderNumber: header.order.orderNumber,
     status: header.order.status as OrderDetail["status"],
-    notes: header.order.notes,
     createdAt: header.order.createdAt,
     updatedAt: header.order.updatedAt,
     customer: {
@@ -132,10 +131,6 @@ export async function updateOrderStatus(context: DatabaseContext, orderId: strin
   await context.db.update(orders).set({ status, updatedAt }).where(eq(orders.id, orderId));
 }
 
-export async function updateOrderNotes(context: DatabaseContext, orderId: string, notes: string, updatedAt: string) {
-  await context.db.update(orders).set({ notes, updatedAt }).where(eq(orders.id, orderId));
-}
-
 export async function updateOrderAddress(context: DatabaseContext, orderId: string, address: Address) {
   const [row] = await context.db.select({ shippingAddressId: orders.shippingAddressId }).from(orders).where(eq(orders.id, orderId));
 

apps/api/src/orders/order-routes.ts

@@ -7,7 +7,6 @@ import { getOrder } from "./get-order";
 import { listAuditEvents } from "./list-audit-events";
 import { listOrders } from "./list-orders";
 import { changeOrderItemQuantity } from "./update-order-item";
-import { changeOrderNotes } from "./update-notes";
 import { changeShippingAddress } from "./update-shipping-address";
 
 interface OrderRouteOptions {
@@ -30,10 +29,6 @@ interface QuantityBody {
   quantity: number;
 }
 
-interface NotesBody {
-  notes: string;
-}
-
 interface CancelBody {
   reason?: string;
 }
@@ -100,31 +95,6 @@ export const registerOrderRoutes: FastifyPluginAsync<OrderRouteOptions> = async
     return result.order;
   });
 
-  app.post<{ Params: IdParams; Body: NotesBody }>("/orders/:orderId/notes", {
-    schema: {
-      body: {
-        type: "object",
-        required: ["notes"],
-        properties: {
-          notes: { type: "string" }
-        }
-      }
-    }
-  }, async (request, reply) => {
-    const currentUser = (request as AuthenticatedRequest).currentUser;
-    const result = await changeOrderNotes(options.db, {
-      orderId: request.params.orderId,
-      notes: request.body.notes,
-      actor: currentUser.username
-    });
-
-    if (result.statusCode !== 200) {
-      return reply.code(result.statusCode).send({ message: result.message });
-    }
-
-    return result.order;
-  });
-
   app.post<{ Params: IdParams; Body: Address }>("/orders/:orderId/shipping-address", {
     schema: {
       body: {

apps/api/src/orders/order-search-assignment-1.test.ts

@@ -7,7 +7,7 @@ let app: AppWithContext;
 let employeeCookie = "";
 
 function firstHeader(value: string | string[] | undefined) {
-  return Array.isArray(value) ? (value[0] ?? "") : value ?? "";
+  return Array.isArray(value) ? value[0] : value ?? "";
 }
 
 async function login(username: string) {
@@ -47,4 +47,64 @@ describe("assignment 1 search behavior", () => {
     expect(orderNumbers).toContain("ORD-1001");
     expect(orderNumbers).toContain("ORD-1003");
   });
+
+  test("searches orders by mixed-case customer name without matching email", async () => {
+    const response = await app.inject({
+      method: "GET",
+      url: "/api/orders?query=JoHn%20SmItH",
+      headers: { cookie: employeeCookie }
+    });
+
+    const orders = response.json();
+    const orderNumbers = orders.map((order: { orderNumber: string }) => order.orderNumber);
+
+    expect(response.statusCode).toBe(200);
+    expect(orderNumbers).toHaveLength(2);
+    expect(orderNumbers).toContain("ORD-1001");
+    expect(orderNumbers).toContain("ORD-1003");
+  });
+
+  test("searches orders by uppercase customer email", async () => {
+    const response = await app.inject({
+      method: "GET",
+      url: "/api/orders?query=JOHN.SMITH%40EXAMPLE.COM",
+      headers: { cookie: employeeCookie }
+    });
+
+    const orders = response.json();
+    const orderNumbers = orders.map((order: { orderNumber: string }) => order.orderNumber);
+
+    expect(response.statusCode).toBe(200);
+    expect(orderNumbers).toHaveLength(2);
+    expect(orderNumbers).toContain("ORD-1001");
+    expect(orderNumbers).toContain("ORD-1003");
+  });
+
+  test("searches orders by lowercase order number", async () => {
+    const response = await app.inject({
+      method: "GET",
+      url: "/api/orders?query=ord-1001",
+      headers: { cookie: employeeCookie }
+    });
+
+    const orders = response.json();
+    const orderNumbers = orders.map((order: { orderNumber: string }) => order.orderNumber);
+
+    expect(response.statusCode).toBe(200);
+    expect(orderNumbers).toHaveLength(1);
+    expect(orderNumbers).toContain("ORD-1001");
+  });
+
+  test("returns no orders when the search term does not match", async () => {
+    const response = await app.inject({
+      method: "GET",
+      url: "/api/orders?query=no-matching-order",
+      headers: { cookie: employeeCookie }
+    });
+
+    const orders = response.json();
+
+    expect(response.statusCode).toBe(200);
+    expect(orders).toEqual([]);
+  });
 });

apps/api/src/orders/update-notes.ts

@@ -1,44 +0,0 @@
-import type { DatabaseContext } from "../db/database";
-import { appendAuditEvent, findOrderDetail, updateOrderNotes } from "./order-repository";
-
-export const NOTES_MAX_LENGTH = 1000;
-
-export async function changeOrderNotes(
-  context: DatabaseContext,
-  input: {
-    orderId: string;
-    notes: string;
-    actor: string;
-  }
-) {
-  const order = await findOrderDetail(context, input.orderId);
-
-  if (!order) {
-    return { statusCode: 404, message: "Order not found." } as const;
-  }
-
-  const notes = input.notes.trim();
-
-  if (notes.length === 0) {
-    return { statusCode: 400, message: "Notes cannot be empty." } as const;
-  }
-
-  if (notes.length > NOTES_MAX_LENGTH) {
-    return { statusCode: 400, message: `Notes cannot exceed ${NOTES_MAX_LENGTH} characters.` } as const;
-  }
-
-  const updatedAt = new Date().toISOString();
-  await updateOrderNotes(context, input.orderId, notes, updatedAt);
-  await appendAuditEvent(context, {
-    orderId: input.orderId,
-    actor: input.actor,
-    type: "order.notes_updated",
-    message: "Updated internal notes.",
-    createdAt: updatedAt
-  });
-
-  return {
-    statusCode: 200,
-    order: await findOrderDetail(context, input.orderId)
-  } as const;
-}

apps/web/src/orders/order-api.ts

@@ -28,13 +28,6 @@ export function updateShippingAddress(orderId: string, address: Address) {
   });
 }
 
-export function updateOrderNotes(orderId: string, notes: string) {
-  return apiRequest<OrderDetail>(`/api/orders/${orderId}/notes`, {
-    method: "POST",
-    body: JSON.stringify({ notes })
-  });
-}
-
 export function cancelOrder(orderId: string, reason?: string) {
   return apiRequest<OrderDetail>(`/api/orders/${orderId}/cancel`, {
     method: "POST",

apps/web/src/orders/order-detail-page.tsx

@@ -1,7 +1,6 @@
 import type { Address, AuditEvent, OrderDetail } from "@orderops/shared";
 import { AuditTimeline } from "./audit-timeline";
 import { OrderItemsPanel } from "./order-items-panel";
-import { OrderNotesPanel } from "./order-notes";
 import { OrderSummaryPanel } from "./order-summary";
 import { ShippingAddressForm } from "./shipping-address-form";
 
@@ -10,7 +9,6 @@ interface OrderDetailPageProps {
   auditEvents: AuditEvent[];
   onUpdateQuantity: (itemId: string, quantity: number) => Promise<void>;
   onSaveAddress: (address: Address) => Promise<void>;
-  onSaveNotes: (notes: string) => Promise<void>;
   onCancel: () => Promise<void>;
 }
 
@@ -19,13 +17,11 @@ export function OrderDetailPage({
   auditEvents,
   onUpdateQuantity,
   onSaveAddress,
-  onSaveNotes,
   onCancel
 }: OrderDetailPageProps) {
   return (
     <div className="space-y-4">
       <OrderSummaryPanel order={order} />
-      <OrderNotesPanel notes={order.notes} onSave={onSaveNotes} />
       <div className="flex justify-end">
         <button className="rounded-md bg-red-600 px-4 py-2 text-sm font-medium text-white" onClick={() => void onCancel()} type="button">
           Cancel order

apps/web/src/orders/order-notes.tsx

@@ -1,60 +0,0 @@
-import { useState } from "react";
-
-export const NOTES_MAX_LENGTH = 1000;
-
-interface OrderNotesProps {
-  notes: string;
-  onSave: (notes: string) => Promise<void>;
-}
-
-export function OrderNotesPanel({ notes, onSave }: OrderNotesProps) {
-  const [draft, setDraft] = useState(notes);
-  const [isSaving, setIsSaving] = useState(false);
-  const trimmed = draft.trim();
-  const isDisabled = isSaving || trimmed.length === 0 || trimmed === notes;
-
-  async function handleSave() {
-    if (isDisabled) {
-      return;
-    }
-
-    setIsSaving(true);
-    try {
-      await onSave(trimmed);
-    } finally {
-      setIsSaving(false);
-    }
-  }
-
-  return (
-    <section className="rounded-xl border border-slate-200 bg-white p-4 shadow-sm">
-      <div className="mb-3 flex items-center justify-between">
-        <h3 className="text-sm font-semibold text-slate-700">Internal notes</h3>
-        <span className="text-xs text-slate-500">{draft.length}/{NOTES_MAX_LENGTH}</span>
-      </div>
-      {notes ? (
-        <p className="mb-3 whitespace-pre-wrap text-sm text-slate-700">{notes}</p>
-      ) : (
-        <p className="mb-3 text-sm text-slate-400">No internal notes yet. Add context for teammates following up on this order.</p>
-      )}
-      <textarea
-        className="w-full resize-y rounded-lg border border-slate-300 px-3 py-2 text-sm text-slate-900 focus:border-blue-500 focus:outline-none"
-        maxLength={NOTES_MAX_LENGTH}
-        onChange={(event) => setDraft(event.target.value)}
-        placeholder="Add internal notes..."
-        rows={3}
-        value={draft}
-      />
-      <div className="mt-3 flex justify-end">
-        <button
-          className="rounded-md bg-blue-600 px-4 py-2 text-sm font-medium text-white disabled:cursor-not-allowed disabled:opacity-50"
-          disabled={isDisabled}
-          onClick={() => void handleSave()}
-          type="button"
-        >
-          {isSaving ? "Saving..." : "Save notes"}
-        </button>
-      </div>
-    </section>
-  );
-}

apps/web/src/orders/order-page.tsx

@@ -2,7 +2,7 @@ import { useEffect, useState } from "react";
 import type { Address, AuditEvent, OrderDetail } from "@orderops/shared";
 import { Link, useParams } from "react-router-dom";
 import { Toast } from "../ui/toast";
-import { cancelOrder, getOrder, listAuditEvents, updateOrderItemQuantity, updateOrderNotes, updateShippingAddress } from "./order-api";
+import { cancelOrder, getOrder, listAuditEvents, updateOrderItemQuantity, updateShippingAddress } from "./order-api";
 import { OrderDetailPage } from "./order-detail-page";
 
 interface ToastState {
@@ -86,7 +86,6 @@ export function OrderPage() {
           auditEvents={auditEvents}
           onUpdateQuantity={(itemId, quantity) => runAction(() => updateOrderItemQuantity(order.id, itemId, quantity), "Quantity saved.")}
           onSaveAddress={(address: Address) => runAction(() => updateShippingAddress(order.id, address), "Shipping address saved.")}
-          onSaveNotes={(notes: string) => runAction(() => updateOrderNotes(order.id, notes), "Notes saved.")}
           onCancel={() => runAction(() => cancelOrder(order.id), "Order cancelled.")}
         />
       ) : null}

packages/shared/src/order-detail.ts

@@ -17,7 +17,6 @@ export interface OrderDetail {
   id: string;
   orderNumber: string;
   status: OrderStatus;
-  notes: string;
   createdAt: string;
   updatedAt: string;
   customer: CustomerSummary;