Fix case-insensitive order search #3

Open
riso8739 wants to merge 1 commits from fix/case-insensitive-search into master
2 changed files with 63 additions and 3 deletions
Showing only changes of commit f4f7f9620f - Show all commits
+3 -3
View File
@@ -39,9 +39,9 @@ export async function listOrderSummaries(context: DatabaseContext, query?: strin
const filters = search const filters = search
? or( ? or(
sql`instr(${orders.orderNumber}, ${search}) > 0`, sql`instr(LOWER(${orders.orderNumber}), LOWER(${search})) > 0`,
Review

Probably better to use lower() on the search above, instead of casting it 3x here.

Probably better to use `lower()` on the `search` above, instead of casting it 3x here.
sql`instr(${users.name}, ${search}) > 0`, sql`instr(LOWER(${users.name}), LOWER(${search})) > 0`,
sql`instr(${users.email}, ${search}) > 0` sql`instr(LOWER(${users.email}), LOWER(${search})) > 0`
) )
: undefined; : undefined;
@@ -47,4 +47,64 @@ describe("assignment 1 search behavior", () => {
expect(orderNumbers).toContain("ORD-1001"); expect(orderNumbers).toContain("ORD-1001");
expect(orderNumbers).toContain("ORD-1003"); expect(orderNumbers).toContain("ORD-1003");
}); });
test("searches orders by mixed-case customer name without matching email", async () => {
const response = await app.inject({
method: "GET",
url: "/api/orders?query=JoHn%20SmItH",
headers: { cookie: employeeCookie }
});
const orders = response.json();
const orderNumbers = orders.map((order: { orderNumber: string }) => order.orderNumber);
expect(response.statusCode).toBe(200);
expect(orderNumbers).toHaveLength(2);
expect(orderNumbers).toContain("ORD-1001");
expect(orderNumbers).toContain("ORD-1003");
});
test("searches orders by uppercase customer email", async () => {
const response = await app.inject({
method: "GET",
url: "/api/orders?query=JOHN.SMITH%40EXAMPLE.COM",
headers: { cookie: employeeCookie }
});
const orders = response.json();
const orderNumbers = orders.map((order: { orderNumber: string }) => order.orderNumber);
expect(response.statusCode).toBe(200);
expect(orderNumbers).toHaveLength(2);
expect(orderNumbers).toContain("ORD-1001");
expect(orderNumbers).toContain("ORD-1003");
});
test("searches orders by lowercase order number", async () => {
const response = await app.inject({
method: "GET",
url: "/api/orders?query=ord-1001",
headers: { cookie: employeeCookie }
});
const orders = response.json();
const orderNumbers = orders.map((order: { orderNumber: string }) => order.orderNumber);
expect(response.statusCode).toBe(200);
expect(orderNumbers).toHaveLength(1);
expect(orderNumbers).toContain("ORD-1001");
});
test("returns no orders when the search term does not match", async () => {
const response = await app.inject({
method: "GET",
url: "/api/orders?query=no-matching-order",
headers: { cookie: employeeCookie }
});
const orders = response.json();
expect(response.statusCode).toBe(200);
expect(orders).toEqual([]);
});
}); });