derrick/ai-wave-02
1
0
Fork 0
Code Issues 4 Pull Requests 17 Actions Packages Projects 1 Releases Wiki Activity

fixed issue with searcing #5

Open
notsicilian wants to merge 3 commits from fs-fix-search-order into master
pull from: fs-fix-search-order
merge into: :master
Conversation 3 Commits 3 Files Changed 12
+4 -4
2 changed files with 4 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files
Showing only changes of commit 8f619214f0 - Show all commits
apps/api/src/orders/order-repository.ts
+3 -3
View File
@@ -39,9 +39,9 @@ export async function listOrderSummaries(context: DatabaseContext, query?: strin
const filters = search
? or(
sql`instr(${orders.orderNumber}, ${search}) > 0`,
sql`instr(${users.name}, ${search}) > 0`,
sql`instr(${users.email}, ${search}) > 0`
sql`instr(lower(${orders.orderNumber}), lower(${search})) > 0`,
derrick commented 2026-09-18 15:41:09 +00:00
Review
Copy Link
Copy Source

Instead of using lower() on search here, apply it above so that we don't cast it 3x here.

Instead of using `lower()` on `search` here, apply it above so that we don't cast it 3x here.
aziz_28002 commented 2026-09-24 14:00:23 +00:00
Review
Copy Link
Copy Source

Clear, Sir I will

Clear, Sir I will
sql`instr(lower(${users.name}), lower(${search})) > 0`,
sql`instr(lower(${users.email}), lower(${search})) > 0`
)
: undefined;
apps/api/src/orders/order-search-assignment-1.test.ts
+1 -1
View File
@@ -7,7 +7,7 @@ let app: AppWithContext;
let employeeCookie = "";
function firstHeader(value: string | string[] | undefined) {
return Array.isArray(value) ? value[0] : value ?? "";
return Array.isArray(value) ? (value[0] ?? "") : value ?? "";
derrick commented 2026-09-18 15:41:23 +00:00
Review
Copy Link
Copy Source

Assignment test should not be modified.

Assignment test should not be modified.
aziz_28002 commented 2026-09-24 14:02:08 +00:00
Review
Copy Link
Copy Source

Clear

Clear
}
async function login(username: string) {