derrick/ai-wave-02
1
0
Fork 0
Code Issues 4 Pull Requests 17 Actions Packages Projects 1 Releases Wiki Activity

fix: make order search case-insensitive #6

Open
aziz_28002 wants to merge 1 commits from fix/order-search-case-insensitive-aziz into master
pull from: fix/order-search-case-insensitive-aziz
merge into: :master
Conversation 2 Commits 1 Files Changed 1
+3 -3
1 changed files with 3 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files
Showing only changes of commit a5bbc24ecf - Show all commits
apps/api/src/orders/order-repository.ts
+3 -3
View File
@@ -39,9 +39,9 @@ export async function listOrderSummaries(context: DatabaseContext, query?: strin
const filters = search const filters = search
? or( ? or(
sql`instr(${orders.orderNumber}, ${search}) > 0`, sql`instr(lower(${orders.orderNumber}), lower(${search})) > 0`,
derrick commented 2026-09-18 15:45:06 +00:00
Review
Copy Link
Copy Source

Should move the lower() to the search above, to avoid casting it 3x here.

Should move the `lower()` to the `search` above, to avoid casting it 3x here.
sql`instr(${users.name}, ${search}) > 0`, sql`instr(lower(${users.name}), lower(${search})) > 0`,
sql`instr(${users.email}, ${search}) > 0` sql`instr(lower(${users.email}), lower(${search})) > 0`
) )
: undefined; : undefined;