derrick/ai-wave-02
1
0
Fork 0
Code Issues 4 Pull Requests 17 Actions Packages Projects 1 Releases Wiki Activity

Fs fix search order v2 #17

Open
notsicilian wants to merge 3 commits from fs-fix-search-order-v2 into master
pull from: fs-fix-search-order-v2
merge into: :master
Conversation 0 Commits 3 Files Changed 12
+269 -5
notsicilian commented 2026-09-29 22:16:37 +00:00
Collaborator
Copy Link
Copy Source

Summary
Operations teammates can now add and update internal notes on an order. Notes persist as part of the order record, providing internal context for follow-up work.

  • Ticket: Assignment 2 - Internal order notes

What changed

  • Added persistent internal notes to order records and existing database initialization.
  • Added an employee-only notes API with empty-note and 1,000-character validation.
  • Added an Internal notes panel to order details with save feedback and audit events.

How to test
bun run check
bun run test
bun run build:web

Manual checks:

  • Sign in as an employee, open an order, add a note, and verify it displays successfully.
  • Refresh the page and confirm the note persists.
  • Update the note and confirm an audit event appears.
  • Confirm empty notes cannot be saved and notes are limited to 1,000 characters.
  • Confirm customer users cannot update internal notes.

Screenshots or recordings
Attach a screenshot or recording of the Internal notes panel.

Risks / follow-ups

  • Saving notes replaces the existing note instead of maintaining a threaded history.
  • Simultaneous edits could overwrite another employee’s changes.

PR checklist

  • change is scoped to one ticket or one small reviewable concern
  • acceptance criteria were checked
  • code follows CONTRIBUTING.md
  • no unrelated refactor is mixed in
  • debug code and temporary logs are removed
  • relevant automated checks were run locally
  • changed behavior was manually tested when needed
  • known risks or follow-ups are called out
Summary Operations teammates can now add and update internal notes on an order. Notes persist as part of the order record, providing internal context for follow-up work. - Ticket: Assignment 2 - Internal order notes What changed - Added persistent internal notes to order records and existing database initialization. - Added an employee-only notes API with empty-note and 1,000-character validation. - Added an Internal notes panel to order details with save feedback and audit events. How to test bun run check bun run test bun run build:web Manual checks: - Sign in as an employee, open an order, add a note, and verify it displays successfully. - Refresh the page and confirm the note persists. - Update the note and confirm an audit event appears. - Confirm empty notes cannot be saved and notes are limited to 1,000 characters. - Confirm customer users cannot update internal notes. Screenshots or recordings Attach a screenshot or recording of the Internal notes panel. Risks / follow-ups - Saving notes replaces the existing note instead of maintaining a threaded history. - Simultaneous edits could overwrite another employee’s changes. ## PR checklist - [ ] change is scoped to one ticket or one small reviewable concern - [ ] acceptance criteria were checked - [ ] code follows `CONTRIBUTING.md` - [ ] no unrelated refactor is mixed in - [ ] debug code and temporary logs are removed - [ ] relevant automated checks were run locally - [ ] changed behavior was manually tested when needed - [ ] known risks or follow-ups are called out
notsicilian added 3 commits 2026-09-29 22:16:38 +00:00
fixed issue with searcing
Runner Test / test (push) Successful in 17s
Details
Runner Test / test (pull_request) Successful in 14s
Details
8f619214f0
add:assignment 2 tests 4f6c68ad29
assignment 2 ui changes
Runner Test / test (push) Successful in 17s
Details
Runner Test / test (pull_request) Successful in 16s
Details
98801089e5
All checks were successful
Runner Test / test (push) Successful in 17s
Details
Runner Test / test (pull_request) Successful in 16s
Details
This pull request has changes conflicting with the target branch.
  • apps/api/src/db/init-db.ts
  • apps/api/src/db/schema/orders.ts
  • apps/api/src/orders/order-repository.ts
  • apps/api/src/orders/order-routes.ts
  • apps/web/src/orders/order-detail-page.tsx
  • apps/web/src/orders/order-notes.tsx
  • apps/web/src/orders/order-page.tsx
View command line instructions

Checkout

From your project repository, check out a new branch and test the changes.
git fetch -u origin fs-fix-search-order-v2:fs-fix-search-order-v2
git checkout fs-fix-search-order-v2
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
No items
No labels
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
ahmedhnoor aziz_28002 cq0622 dsel karinah0333_16363 notsicilian riso8739 derrick
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: derrick/ai-wave-02#17