This is fine for sharing a simple value across frontend and backend. I think a better way to make it more explicit is to encapsulate it by relation, so make it so that you can use it like: orderConstraints.notes.maxLength or similar, this way we can also easily add any other constraints when needed.
8235ceb61f
Merge pull request 'Feature Internal Order Notes' (#12) from feat/dg-2-internal-order-notes into master
Code is good. Summary should be about the PR, not the ticket. Otherwise, good job on getting the assignment test to pass.
Summary needs to be about the PR, not the ticket. Can just link the ticket next time in ticket/assignment section. Otherwise, good job on getting the assignment test to pass.
Should move the lower() to the search above, to avoid casting it 3x here.
Summary needs to be the summary of the PR, not the ticket. Can just link the ticket in ticket/assignment next time. The update to the code should pass the test, just that a slight change would be…
Instead of using lower() on search here, apply it above so that we don't cast it 3x here.
Code is good. Add the ticket link next time, and maybe think about some risks/follow up. Otherwise good job at getting the assignment test to pass.
Description is short and good, "How to test" section is not correct. Otherwise, good job on getting the assignment test to pass
Probably better to use lower() on the search above, instead of casting it 3x here.
PR Description and contents a little verbose, but otherwise a good job at getting the assignment test to pass.