877eb9e09a
Merge pull request 'Fix Item Quantity Update Constraints' (#21) from fix/dg-3-item-quantity-update-constraints into master
PR is too wordy, a lot of the test information is not needed. Just give the reviewer short and concise instructions on the command for running tests, and how to test manually. Would be better to…
It would be better to not hard code values here.
It would be better to not hard code values here.
PR descriptions are good, it's fine that assignment 1 is failing. Good job on getting the tests to pass.
Code is good, this would easily pass a simple feature addition. PR is a little wordy, but otherwise good job.
This is fine for sharing a simple value across frontend and backend. I think a better way to make it more explicit is to encapsulate it by relation, so make it so that you can use it like: orderConstraints.notes.maxLength or similar, this way we can also easily add any other constraints when needed.
While a separate table has it's upsides for auditing, I think that the scope of the notes that was wanted by the ticket is simple enough to add it onto the orders table, instead of creating a new table for the notes specifically.
It would be better to not hard code values here.
It would be better to not hard code values here.
Everything looks fine, this should easily pass as a simple feature addition at most places. Good job.